Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recursive join rel filter #1726

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Recursive join rel filter #1726

merged 1 commit into from
Jun 28, 2023

Conversation

andyfengHKU
Copy link
Contributor

No description provided.

@andyfengHKU andyfengHKU requested a review from ray6080 June 27, 2023 17:44
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (429d37f) 91.35% compared to head (75358d4) 91.34%.

❗ Current head 75358d4 differs from pull request most recent head 687cfbd. Consider uploading reports for the commit 687cfbd to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1726      +/-   ##
==========================================
- Coverage   91.35%   91.34%   -0.01%     
==========================================
  Files         749      749              
  Lines       27251    27264      +13     
==========================================
+ Hits        24894    24905      +11     
- Misses       2357     2359       +2     
Impacted Files Coverage Δ
src/include/binder/binder.h 100.00% <ø> (ø)
src/binder/bind/bind_graph_pattern.cpp 95.47% <100.00%> (+0.14%) ⬆️
...inder/bind_expression/bind_subquery_expression.cpp 100.00% <100.00%> (ø)
src/binder/binder.cpp 96.33% <100.00%> (ø)
...c/include/parser/query/graph_pattern/rel_pattern.h 100.00% <100.00%> (ø)
src/parser/transformer.cpp 95.77% <100.00%> (+0.02%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@ray6080 ray6080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one general comment, I think it's better to closely follow existing MemGraph syntax, though we didn;t support filter predicates on node variables now, still the syntax should be [e:knows*1..2 (r,n | WHERE list_contains(r.comments, 'rnme'))] or [e:knows*1..2 (r,_ | WHERE list_contains(r.comments, 'rnme'))]

@andyfengHKU andyfengHKU merged commit faada3f into master Jun 28, 2023
9 checks passed
@andyfengHKU andyfengHKU deleted the recursive-join-rel-filter branch June 28, 2023 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants