Fix use of PreparedStatement in releases #1725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this could also be fixed by explicitly using the default destructor for |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1725 +/- ##
=======================================
Coverage 91.34% 91.34%
=======================================
Files 749 749
Lines 27250 27251 +1
=======================================
+ Hits 24891 24892 +1
Misses 2359 2359
☔ View full report in Codecov by Sentry. |
Without the explicit desctructor, using unique_ptr<PreparedStatement> requires extra includes since the types of some of its fields are incomplete, and the necessary header files are unavailable in the single-file header included in the releases.
benjaminwinger
changed the title
benjaminwinger
force-pushed
the
prepared-statement-fix
branch
from
2a0ec2f
to
5e3ec39
Compare
andyfengHKU
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using forward declarations.The forward declarations prevent using
unique_ptr<PreparedStatement>without extra includes since the type is incomplete, and the necessary header files are unavailable in the single-file header included in the releases.This is necessary both to compile the rust API against the releases, as well as to use the
Connection::preparefunction in the C++ API from the releases.Were forward declarations being used to try and keep BoundStatementResult and LogicalPlan out of the public API, or was it just to try and reduce the number of includes/deal with cyclic includes?Edit: Explicitly declaring the default destructor fixes the issue without changing the includes.