Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 1704 #1723

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Fix issue 1704 #1723

merged 1 commit into from
Jun 26, 2023

Conversation

ray6080
Copy link
Contributor

@ray6080 ray6080 commented Jun 25, 2023

No description provided.

@ray6080 ray6080 requested a review from acquamarin June 25, 2023 16:28
@ray6080 ray6080 changed the title Fix issue 1702 Fix issue 1704 Jun 26, 2023
dataset/primary-key-tests/eFollows.csv Outdated Show resolved Hide resolved
dataset/primary-key-tests/vOrg.csv Outdated Show resolved Hide resolved
@ray6080 ray6080 force-pushed the fix-1704 branch 3 times, most recently from ccd859c to ab919c0 Compare June 26, 2023 01:46
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (b802bd6) 91.32% compared to head (80e3876) 91.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1723      +/-   ##
==========================================
+ Coverage   91.32%   91.34%   +0.02%     
==========================================
  Files         749      749              
  Lines       27252    27250       -2     
==========================================
+ Hits        24888    24892       +4     
+ Misses       2364     2358       -6     
Impacted Files Coverage Δ
src/include/catalog/catalog.h 100.00% <ø> (ø)
src/include/storage/copier/rel_copy_executor.h 100.00% <ø> (ø)
src/catalog/catalog.cpp 89.88% <100.00%> (+0.15%) ⬆️
src/include/catalog/catalog_structs.h 100.00% <100.00%> (ø)
src/include/processor/operator/copy/read_csv.h 100.00% <100.00%> (ø)
src/include/storage/copier/rel_copier.h 94.87% <100.00%> (-0.13%) ⬇️
src/include/storage/storage_info.h 100.00% <100.00%> (ø)
src/processor/operator/copy/copy_rel.cpp 100.00% <100.00%> (ø)
src/processor/operator/ddl/create_rel_table.cpp 100.00% <100.00%> (ø)
src/storage/copier/rel_copier.cpp 97.80% <100.00%> (+0.02%) ⬆️
... and 2 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ray6080 ray6080 merged commit ea9c21e into master Jun 26, 2023
9 checks passed
@ray6080 ray6080 deleted the fix-1704 branch June 26, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants