Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recursive join key equality comparison #1721

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

andyfengHKU
Copy link
Contributor

No description provided.

@andyfengHKU andyfengHKU requested a review from ray6080 June 25, 2023 06:30
@codecov
Copy link

codecov bot commented Jun 25, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (67eb0c2) 91.32% compared to head (fe87e5b) 91.32%.

❗ Current head fe87e5b differs from pull request most recent head 4d64fec. Consider uploading reports for the commit 4d64fec to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1721   +/-   ##
=======================================
  Coverage   91.32%   91.32%           
=======================================
  Files         749      749           
  Lines       27243    27252    +9     
=======================================
+ Hits        24880    24889    +9     
  Misses       2363     2363           
Impacted Files Coverage Δ
src/include/binder/binder.h 100.00% <ø> (ø)
...rc/include/binder/expression/node_rel_expression.h 100.00% <ø> (ø)
src/include/binder/expression_binder.h 100.00% <ø> (ø)
.../include/binder/query/reading_clause/query_graph.h 96.66% <ø> (ø)
src/include/planner/join_order_enumerator.h 100.00% <ø> (ø)
src/planner/join_order_enumerator.cpp 97.64% <ø> (ø)
src/planner/query_planner.cpp 93.83% <ø> (-0.54%) ⬇️
src/binder/bind/bind_graph_pattern.cpp 95.32% <100.00%> (+0.11%) ⬆️
src/binder/bind/bind_reading_clause.cpp 91.66% <100.00%> (-0.65%) ⬇️
src/binder/bind/bind_updating_clause.cpp 95.53% <100.00%> (ø)
... and 8 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@andyfengHKU andyfengHKU merged commit b802bd6 into master Jun 26, 2023
9 checks passed
@andyfengHKU andyfengHKU deleted the recursive-join-key-val-pair branch June 26, 2023 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants