Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing framework adjustments #1719

Merged
merged 4 commits into from
Jun 26, 2023

Conversation

rfdavid
Copy link
Collaborator

@rfdavid rfdavid commented Jun 25, 2023

This PR addresses the feedback from the testing framework presentation.

  • Replace .csv extension with .txt inside /answers directory
  • Change -NAME to -DEBUG_LOG. Spaces are allowed in front of the tag. For example, instead of writing -DEBUG_LOG SingletonNodeBackwardCheck, it's possible to write -DEBUG_LOG Check singleton node backwards
  • Remove -QUERY statement. Only -STATEMENT will be allowed
  • Change -STATEMENT_BLOCK to -INSERT_STATEMENT_BLOCK to make it more explicit
  • Replace a long text with ARANGE on Unwind test

* Change answers/*.csv to answers/*.txt
* Replace STATEMENT_BLOCK by INSERT_STATEMENT_BLOCK
* Replace NAME by DEBUG_LOG
* Use ARANGE in UNWIND test
@codecov
Copy link

codecov bot commented Jun 25, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2c21a5e) 91.32% compared to head (f3948ab) 91.32%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1719   +/-   ##
=======================================
  Coverage   91.32%   91.32%           
=======================================
  Files         749      749           
  Lines       27243    27243           
=======================================
+ Hits        24880    24881    +1     
+ Misses       2363     2362    -1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@ray6080 ray6080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would consider replace -DEBUG_LOG with -LOG, which is shorter but convey the same meaning, but up to you.

@rfdavid rfdavid force-pushed the testing_framework_adjustments branch from 0a6e8a6 to f3948ab Compare June 25, 2023 21:09
@rfdavid rfdavid merged commit 67eb0c2 into kuzudb:master Jun 26, 2023
9 checks passed
@rfdavid rfdavid deleted the testing_framework_adjustments branch June 26, 2023 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants