Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement call statement #1717

Merged
merged 1 commit into from
Jun 23, 2023
Merged

Implement call statement #1717

merged 1 commit into from
Jun 23, 2023

Conversation

acquamarin
Copy link
Collaborator

@acquamarin acquamarin commented Jun 23, 2023

This is the first PR to allow user change database configurations through CALL statements.
There are three types of CALL statements:

  1. CALL statement which only change the client context related configurations. (e.g. numThreads, timeoutValue)
  2. CALL statement which changes the global database configurations. (e.g. max recurssive depth)
  3. CALL statement which is treated as functions. (e.g. TABLE_INFO)

@acquamarin acquamarin changed the title Implement call framework Implement call statement Jun 23, 2023
@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.07 🎉

Comparison is base (527f5e9) 91.26% compared to head (4597bd4) 91.34%.

❗ Current head 4597bd4 differs from pull request most recent head bdec9d7. Consider uploading reports for the commit bdec9d7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1717      +/-   ##
==========================================
+ Coverage   91.26%   91.34%   +0.07%     
==========================================
  Files         738      749      +11     
  Lines       27061    27253     +192     
==========================================
+ Hits        24698    24893     +195     
+ Misses       2363     2360       -3     
Impacted Files Coverage Δ
src/include/binder/binder.h 100.00% <ø> (ø)
src/include/common/statement_type.h 100.00% <ø> (ø)
src/include/common/types/types.h 100.00% <ø> (ø)
src/include/main/connection.h 100.00% <ø> (ø)
src/include/parser/transformer.h 100.00% <ø> (ø)
...ical_plan/logical_operator/base_logical_operator.h 100.00% <ø> (ø)
src/include/processor/mapper/plan_mapper.h 100.00% <ø> (ø)
src/include/processor/operator/physical_operator.h 100.00% <ø> (ø)
src/binder/bind/bind_call.cpp 100.00% <100.00%> (ø)
src/binder/binder.cpp 96.33% <100.00%> (+0.06%) ⬆️
... and 17 more

... and 20 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

src/antlr4/Cypher.g4 Outdated Show resolved Hide resolved
src/antlr4/Cypher.g4 Show resolved Hide resolved
test/main/call_test.cpp Show resolved Hide resolved
src/function/built_in_vector_operations.cpp Show resolved Hide resolved
src/include/common/types/types.h Outdated Show resolved Hide resolved
src/include/processor/operator/call.h Show resolved Hide resolved
src/include/processor/operator/call.h Outdated Show resolved Hide resolved
src/include/main/settings.h Show resolved Hide resolved
src/binder/bind/bind_call.cpp Outdated Show resolved Hide resolved
@acquamarin acquamarin merged commit 2c21a5e into master Jun 23, 2023
9 checks passed
@acquamarin acquamarin deleted the call branch June 23, 2023 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants