Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement struct/list comparison operations #1707

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

acquamarin
Copy link
Collaborator

@acquamarin acquamarin commented Jun 21, 2023

This PR refactors the current comparison framework as well as adding comparison operations for STRUCT/LIST.

@acquamarin acquamarin changed the title Struct list operations Implement struct/list comparison operations Jun 21, 2023
@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Patch coverage: 91.73% and project coverage change: +0.05 🎉

Comparison is base (75617bb) 91.21% compared to head (4f69f02) 91.26%.

❗ Current head 4f69f02 differs from pull request most recent head e954f7f. Consider uploading reports for the commit e954f7f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1707      +/-   ##
==========================================
+ Coverage   91.21%   91.26%   +0.05%     
==========================================
  Files         737      738       +1     
  Lines       26969    27061      +92     
==========================================
+ Hits        24600    24698      +98     
+ Misses       2369     2363       -6     
Impacted Files Coverage Δ
src/common/type_utils.cpp 70.49% <ø> (+3.82%) ⬆️
src/include/common/type_utils.h 100.00% <ø> (ø)
src/include/common/types/value.h 100.00% <ø> (ø)
src/include/main/connection.h 100.00% <ø> (ø)
src/include/main/query_result.h 100.00% <ø> (ø)
...rocessor/operator/aggregate/aggregate_hash_table.h 81.81% <ø> (ø)
src/include/processor/result/flat_tuple.h 100.00% <ø> (ø)
src/include/storage/copier/npy_reader.h 100.00% <ø> (ø)
...age/in_mem_storage_structure/in_mem_column_chunk.h 100.00% <ø> (ø)
...ude/storage/storage_structure/disk_overflow_file.h 100.00% <ø> (ø)
... and 15 more

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@acquamarin acquamarin merged commit 527f5e9 into master Jun 22, 2023
9 checks passed
@acquamarin acquamarin deleted the struct-list-operations branch June 22, 2023 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants