Rust API on Windows

[benjaminwinger]

I've managed to get rust working on Windows, with the exception that compiling against the debug version doesn't work very well, so I've set it to link against the release version in both debug and release mode on Windows (it only works if you override the CFLAGS/CXXFLAGS environment variables, but it's not sufficient to do that in build.rs since it has to also affect one of the dependencies).

[codecov]

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.08 🎉

Comparison is base (75617bb) 91.21% compared to head (ac9250f) 91.29%.

❗ Current head ac9250f differs from pull request most recent head 9d6d9a2. Consider uploading reports for the commit 9d6d9a2 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1703      +/-   ##
==========================================
+ Coverage   91.21%   91.29%   +0.08%     
==========================================
  Files         737      740       +3     
  Lines       26969    27160     +191     
==========================================
+ Hits        24600    24797     +197     
+ Misses       2369     2363       -6     

Impacted Files	Coverage Δ
src/include/common/types/value.h	100.00% <ø> (ø)
src/include/main/connection.h	100.00% <ø> (ø)
src/include/main/query_result.h	100.00% <ø> (ø)
src/include/processor/result/flat_tuple.h	100.00% <ø> (ø)
src/common/types/value.cpp	91.28% <100.00%> (ø)
src/main/connection.cpp	94.40% <100.00%> (ø)
src/main/query_result.cpp	76.97% <100.00%> (ø)
src/processor/result/flat_tuple.cpp	90.90% <100.00%> (ø)

... and 40 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[benjaminwinger]

I ran into the same issue with arrow and openssl that I did with the Linux tests. It seems that the arrow_bundled_dependencies library will use openssl if it finds it on your system, regardless of whether or not ARROW_USE_OPENSSL is enabled (I'm not sure why; as far as I can tell parquet is compiling the nossl version of their encryption_internal code).

I've set it up to link against openssl when running the tests on windows, but it does have more difficulty finding it than on Linux. Adding the openssl-sys crate as a dependency on Windows helps with finding the library, but you either need vcpkg to detect it (something the openssl-sys error message mentions), or to manually set OPENSSL_DIR (which I've included in the github workflow). I might have to look into how using vcpkg works, but if we're relying on OPENSSL_DIR it might make more sense to just add ${OPENSSL_DIR}/lib to the linker search paths ourselves since the openssl rust bindings from openssl-sys aren't needed.