Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension of PyQueryResult #1700

Merged
merged 3 commits into from
Jun 22, 2023
Merged

Extension of PyQueryResult #1700

merged 3 commits into from
Jun 22, 2023

Conversation

lehners
Copy link
Contributor

@lehners lehners commented Jun 21, 2023

add getExecutionTime, getCompilingTime, and getNumTuples to python api.

I have read and agree to the terms under CLA.md

@mewim
Copy link
Collaborator

mewim commented Jun 21, 2023

Hi @lehners,

Thanks for your contribution.

Could you please take a look at our CLA and add “I have read and agree to the terms under CLA.md” to your PR description if you agree with the CLA?


size_t PyQueryResult::getNumTuples() {
return queryResult->getNumTuples();
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a new line here

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Patch coverage: 40.00% and project coverage change: +0.02 🎉

Comparison is base (75526c9) 91.21% compared to head (bdd6de1) 91.24%.

❗ Current head bdd6de1 differs from pull request most recent head c138ccb. Consider uploading reports for the commit c138ccb to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1700      +/-   ##
==========================================
+ Coverage   91.21%   91.24%   +0.02%     
==========================================
  Files         737      738       +1     
  Lines       26969    27070     +101     
==========================================
+ Hits        24601    24701     +100     
- Misses       2368     2369       +1     
Impacted Files Coverage Δ
tools/python_api/src_cpp/include/py_query_result.h 100.00% <ø> (ø)
tools/python_api/src_cpp/py_query_result.cpp 93.10% <40.00%> (-3.96%) ⬇️

... and 20 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mewim mewim merged commit 50a1310 into kuzudb:master Jun 22, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants