Implement loader for blob type #1693
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1693 +/- ##
==========================================
- Coverage 91.16% 91.14% -0.02%
==========================================
Files 735 735
Lines 26773 26796 +23
==========================================
+ Hits 24407 24424 +17
- Misses 2366 2372 +6
☔ View full report in Codecov by Sentry. |
| @@ -28,7 +28,7 @@ def init_tiny_snb(tmp_path): | |||
| "STRING[], stock STRUCT(price INT64[], volume INT64)), PRIMARY KEY (ID));") | |||
| conn.execute('COPY organisation FROM "../../../dataset/tinysnb/vOrganisation.csv"') | |||
| conn.execute('CREATE NODE TABLE movies (name STRING, length INT32, note STRING, description STRUCT(rating DOUBLE, ' | |||
| 'views INT64, release TIMESTAMP, film DATE), PRIMARY KEY (name))') | |||
| 'views INT64, release TIMESTAMP, film DATE), content BYTEA, PRIMARY KEY (name))') | |||
There was a problem hiding this comment.
You can leave this to others. But we should just let python test to read from schema.cypher and copy.cypher so that we don't need to change this. I guess there is an issue about refactor python test and you can add this to that issue
| common::Blob::fromString(input, result.value.getDataWritable()); | ||
| common::Blob::fromString(reinterpret_cast<const char*>(input.getData()), input.len, | ||
| result.value.getDataWritable()); | ||
| if (!common::ku_string_t::isShortString(result.value.len)) { |
There was a problem hiding this comment.
I wonder if we can have a addBlob function in StringVector. If not, merge the check between l55 and l62
There was a problem hiding this comment.
We can't merge l62-64 to l55, because we can only copy the string prefix after we have done copying the overflowbuffer.
Implement data loading for BLOB type.
DDL grammar to define a blob property:
propertyNAME BYTEA