Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement blob dataType #1690

Merged
merged 1 commit into from
Jun 18, 2023
Merged

Implement blob dataType #1690

merged 1 commit into from
Jun 18, 2023

Conversation

acquamarin
Copy link
Collaborator

@acquamarin acquamarin commented Jun 18, 2023

This is the first set of PRs to implement BLOB datatype in Kùzu.
Implements UNION functions:
BLOB(STRING) => cast a string to blob
OCTET_LENGTH(BLOB) => number of bytes in blob
DECODE(BLOB) => Convert blob to varchar. Fails if blob is not valid utf-8.
ENCODE(BLOB) => Convert varchar to blob. Converts utf-8 characters into literal encoding.

@codecov
Copy link

codecov bot commented Jun 18, 2023

Codecov Report

Patch coverage: 87.02% and project coverage change: -0.01 ⚠️

Comparison is base (c6ca558) 91.17% compared to head (f4a0e82) 91.17%.

❗ Current head f4a0e82 differs from pull request most recent head 9a1da55. Consider uploading reports for the commit 9a1da55 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1690      +/-   ##
==========================================
- Coverage   91.17%   91.17%   -0.01%     
==========================================
  Files         730      735       +5     
  Lines       26662    26773     +111     
==========================================
+ Hits        24310    24409      +99     
- Misses       2352     2364      +12     
Impacted Files Coverage Δ
src/include/common/types/types.h 100.00% <ø> (ø)
src/include/function/built_in_vector_operations.h 100.00% <ø> (ø)
src/include/function/cast/vector_cast_operations.h 91.66% <ø> (ø)
src/include/parser/transformer.h 100.00% <ø> (ø)
src/processor/operator/copy/copy_node.cpp 97.95% <ø> (ø)
src/storage/storage_structure/column.cpp 85.30% <0.00%> (-0.41%) ⬇️
...c/storage/storage_structure/disk_overflow_file.cpp 79.88% <0.00%> (-0.47%) ⬇️
src/common/types/types.cpp 88.80% <50.00%> (-0.24%) ⬇️
src/function/vector_cast_operations.cpp 82.94% <80.00%> (-0.12%) ⬇️
src/common/types/blob.cpp 83.33% <83.33%> (ø)
... and 17 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

test/test_files/tinysnb/projection/single_label.test Outdated Show resolved Hide resolved
src/common/types/types.cpp Outdated Show resolved Hide resolved
src/include/common/types/value.h Outdated Show resolved Hide resolved
src/include/function/built_in_vector_operations.h Outdated Show resolved Hide resolved
src/include/function/cast/cast_operations.h Outdated Show resolved Hide resolved
src/common/types/value.cpp Outdated Show resolved Hide resolved
@acquamarin acquamarin merged commit d7c2cab into master Jun 18, 2023
8 checks passed
@acquamarin acquamarin deleted the blob-type branch June 18, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants