Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove copyNonNullDataWithSameTypeIntoPos #1687

Merged
merged 1 commit into from
Jun 17, 2023

Conversation

andyfengHKU
Copy link
Contributor

No description provided.

src/common/vector/value_vector.cpp Outdated Show resolved Hide resolved
@andyfengHKU andyfengHKU force-pushed the remove-copyNonNullDataWithSameTypeIntoPos branch from 3d7a8ec to c28273f Compare June 17, 2023 17:03
@codecov
Copy link

codecov bot commented Jun 17, 2023

Codecov Report

Patch coverage: 94.84% and no project coverage change.

Comparison is base (994daff) 91.17% compared to head (c28273f) 91.17%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1687   +/-   ##
=======================================
  Coverage   91.17%   91.17%           
=======================================
  Files         731      731           
  Lines       26650    26652    +2     
=======================================
+ Hits        24297    24300    +3     
+ Misses       2353     2352    -1     
Impacted Files Coverage Δ
src/include/common/types/types.h 100.00% <ø> (ø)
src/include/common/vector/value_vector.h 100.00% <ø> (ø)
src/include/processor/result/factorized_table.h 96.82% <ø> (ø)
src/processor/result/factorized_table.cpp 95.62% <81.25%> (+0.09%) ⬆️
src/common/types/types.cpp 89.03% <92.59%> (+0.27%) ⬆️
src/common/vector/value_vector.cpp 100.00% <100.00%> (ø)
src/common/vector/value_vector_utils.cpp 100.00% <100.00%> (ø)
src/include/function/aggregate/collect.h 89.79% <100.00%> (ø)
src/processor/mapper/map_expressions_scan.cpp 100.00% <100.00%> (ø)
src/processor/mapper/map_hash_join.cpp 100.00% <100.00%> (ø)
... and 5 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@andyfengHKU andyfengHKU merged commit 12aec42 into master Jun 17, 2023
8 checks passed
@andyfengHKU andyfengHKU deleted the remove-copyNonNullDataWithSameTypeIntoPos branch June 17, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants