Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove overflow buffer utils #1684

Merged
merged 1 commit into from
Jun 16, 2023
Merged

Conversation

andyfengHKU
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (054ac20) 91.16% compared to head (b81224a) 91.17%.

❗ Current head b81224a differs from pull request most recent head f892058. Consider uploading reports for the commit f892058 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1684   +/-   ##
=======================================
  Coverage   91.16%   91.17%           
=======================================
  Files         733      731    -2     
  Lines       26623    26649   +26     
=======================================
+ Hits        24270    24296   +26     
  Misses       2353     2353           
Impacted Files Coverage Δ
src/common/vector/auxiliary_buffer.cpp 89.47% <ø> (-1.01%) ⬇️
src/include/common/types/ku_list.h 100.00% <ø> (ø)
src/include/common/vector/value_vector.h 100.00% <ø> (ø)
src/include/function/aggregate/collect.h 89.79% <ø> (ø)
src/include/function/cast/cast_operations.h 98.11% <ø> (ø)
...e/function/list/operations/list_append_operation.h 100.00% <ø> (ø)
src/storage/storage_structure/column.cpp 85.71% <ø> (ø)
src/common/types/ku_string.cpp 100.00% <100.00%> (ø)
src/common/vector/value_vector.cpp 100.00% <100.00%> (ø)
src/common/vector/value_vector_utils.cpp 100.00% <100.00%> (ø)
... and 5 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

src/include/common/types/ku_string.h Outdated Show resolved Hide resolved
src/storage/storage_structure/disk_overflow_file.cpp Outdated Show resolved Hide resolved
src/storage/storage_structure/disk_overflow_file.cpp Outdated Show resolved Hide resolved
@andyfengHKU andyfengHKU force-pushed the overflow-buffer-util-refactor branch from b81224a to f892058 Compare June 16, 2023 19:26
@andyfengHKU andyfengHKU merged commit 994daff into master Jun 16, 2023
6 checks passed
@andyfengHKU andyfengHKU deleted the overflow-buffer-util-refactor branch June 16, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants