Change recursive rel physical type #1674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyfengHKU
commented
Jun 13, 2023
src/include/processor/operator/recursive_extend/recursive_join.h
Outdated
Show resolved
Hide resolved
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1674 +/- ##
==========================================
- Coverage 91.44% 91.43% -0.01%
==========================================
Files 730 730
Lines 26455 26475 +20
==========================================
+ Hits 24191 24208 +17
- Misses 2264 2267 +3
☔ View full report in Codecov by Sentry. |
acquamarin
approved these changes
Jun 13, 2023
| @@ -144,15 +144,18 @@ void FactorizedTable::lookup(std::vector<ValueVector*>& vectors, | |||
| uint64_t numTuplesToRead) const { | |||
| assert(vectors.size() == colIdxesToScan.size()); | |||
| for (auto i = 0u; i < colIdxesToScan.size(); i++) { | |||
| auto vector = vectors[i]; | |||
| // TODO(Xiyang/Ziyi): we should set up a rule about when to reset. Should it be in operator? | |||
| vector->resetAuxiliaryBuffer(); | |||
There was a problem hiding this comment.
Maybe the source operator of each pipeline should be responsible for resetting the vector state?
We may need an api in vector which resets the current state of the vector.
andyfengHKU
force-pushed
the
change-recursive-rel-physical-type
branch
from
b18b786
to
aa21181
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the physical type of recursive rel from
LIST[ID]toSTRUCT(LIST[ID], LIST[ID])which lays the foundation for our final goal which is to model recursive rel asSTRUCT(LIST[STRUCT], LIST[STRUCT])This PR also fixes some of the bugs related to reset overflow buffer and factorized table scan