Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CSV->Parquet conversion to test register instance #1656

Merged
merged 2 commits into from
Jun 10, 2023

Conversation

rfdavid
Copy link
Collaborator

@rfdavid rfdavid commented Jun 9, 2023

  • Move CSV->Parquet conversion out of the parsing step to only run when the test runs
  • Create TestEnvironment to set up and tear down parquet temp directory

@rfdavid rfdavid requested a review from ray6080 June 9, 2023 17:45
@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (976d035) 91.45% compared to head (e0c46fe) 91.45%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1656   +/-   ##
=======================================
  Coverage   91.45%   91.45%           
=======================================
  Files         726      726           
  Lines       26411    26411           
=======================================
  Hits        24153    24153           
  Misses       2258     2258           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rfdavid rfdavid merged commit 540ee67 into kuzudb:master Jun 10, 2023
8 checks passed
@rfdavid rfdavid deleted the test_run_adjustments branch June 10, 2023 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants