Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scan and parse test files only once #1654

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

rfdavid
Copy link
Collaborator

@rfdavid rfdavid commented Jun 9, 2023

This PR implements scanning and parsing the test files only once instead of every e2e_test run.

closes #1651

@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03 ⚠️

Comparison is base (322dab6) 91.49% compared to head (3df06f2) 91.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1654      +/-   ##
==========================================
- Coverage   91.49%   91.46%   -0.03%     
==========================================
  Files         727      726       -1     
  Lines       26386    26411      +25     
==========================================
+ Hits        24141    24158      +17     
- Misses       2245     2253       +8     

see 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@ray6080 ray6080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should just not rely on ctest, but directly run e2e_test binary?

@rfdavid
Copy link
Collaborator Author

rfdavid commented Jun 9, 2023

I wonder if we should just not rely on ctest, but directly run e2e_test binary?

Yes, we can directly run e2e_test binary by passing the test file or directory. We use ctest utility to organize what tests to run and provide a nice output. If we are going to run e2e_test directly, we will have to create a minimal utility to organize what tests to run, perform e2e_test passing the file, capture the output, summarize and print the results. We can have more control. It might be a good alternative.

@rfdavid rfdavid merged commit 976d035 into kuzudb:master Jun 9, 2023
8 checks passed
@rfdavid rfdavid deleted the test_performance_issue branch June 9, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test performance drops quickly after running LSQB test
2 participants