Java-API implementation #1650
Merged
Java-API implementation #1650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skipped functions that require prepared statements. Need to test after KuzuQueryResult is implemented.
Changed binding logic for PreparedStatement Note: the c++ implementation of FlatTuple also returns one Value at a time
Need to review use of generics
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #1650 +/- ##
==========================================
- Coverage 91.93% 91.49% -0.45%
==========================================
Files 685 727 +42
Lines 24640 26386 +1746
==========================================
+ Hits 22654 24142 +1488
- Misses 1986 2244 +258 ☔ View full report in Codecov by Sentry. |
|
Tests added |
|
Please remove commented-out code. |
All commented code removde |
mewim
reviewed
Jun 20, 2023
mewim
reviewed
Jun 20, 2023
mewim
reviewed
Jun 20, 2023
mewim
reviewed
Jun 20, 2023
mewim
reviewed
Jun 20, 2023
mewim
reviewed
Jun 20, 2023
mewim
reviewed
Jun 20, 2023
mewim
reviewed
Jun 20, 2023
|
Let's still implement the |
|
All changes done |
mewim
reviewed
Jun 21, 2023
| tempDir.toFile().deleteOnExit(); | ||
|
|
||
| BufferedReader reader; | ||
| db = new KuzuDatabase("java_api_test_db", 0); |
There was a problem hiding this comment.
You added a temporary directory but did use it for the tests.
mewim
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.