Rework copy transaction to not rely on file renaming #1649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1649 +/- ##
==========================================
- Coverage 91.45% 91.44% -0.01%
==========================================
Files 726 727 +1
Lines 26411 26396 -15
==========================================
- Hits 24153 24138 -15
Misses 2258 2258
☔ View full report in Codecov by Sentry. |
acquamarin
approved these changes
Jun 9, 2023
| @@ -40,8 +40,8 @@ void CopyNodeSharedState::initializeColumns( | |||
| // Skip SERIAL, as it is not physically stored. | |||
| continue; | |||
| } | |||
| auto fPath = storage::StorageUtils::getNodePropertyColumnFName(directory, | |||
| nodeTableSchema->tableID, property.propertyID, common::DBFileType::WAL_VERSION); | |||
| auto fPath = storage::StorageUtils::getNodePropertyColumnFName( | |||
There was a problem hiding this comment.
I think we can remove the dbfile type parameter from the getNodePropertyColumnFName, since we are always getting the original version of the node file
| @@ -36,15 +36,15 @@ std::unique_ptr<DirectedInMemRelData> RelCopyExecutor::initializeDirectedInMemRe | |||
| auto relColumns = std::make_unique<DirectedInMemRelColumns>(); | |||
| relColumns->adjColumn = std::make_unique<InMemColumn>( | |||
| StorageUtils::getAdjColumnFName( | |||
| outputDirectory, tableSchema->tableID, direction, DBFileType::WAL_VERSION), | |||
| outputDirectory, tableSchema->tableID, direction, DBFileType::ORIGINAL), | |||
There was a problem hiding this comment.
Ditto, we can remove the dbfiletype parameter
ray6080
force-pushed
the
transaction
branch
2 times, most recently
from
14098f5
to
5f1baf4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.