Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement query processing for map dataType #1648

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Conversation

acquamarin
Copy link
Collaborator

@acquamarin acquamarin commented Jun 7, 2023

Implement query-processing for map dataType.
Grammar to create a map: map([keys], [values])

@acquamarin acquamarin changed the title Implement map-literal Implement query processing for map dataType Jun 7, 2023
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Patch coverage: 96.17% and project coverage change: -0.02 ⚠️

Comparison is base (20d696a) 91.50% compared to head (efabd0c) 91.49%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1648      +/-   ##
==========================================
- Coverage   91.50%   91.49%   -0.02%     
==========================================
  Files         725      727       +2     
  Lines       26335    26386      +51     
==========================================
+ Hits        24099    24141      +42     
- Misses       2236     2245       +9     
Impacted Files Coverage Δ
src/include/common/types/types.h 100.00% <ø> (ø)
src/include/common/vector/auxiliary_buffer.h 90.90% <ø> (ø)
src/include/common/vector/value_vector.h 100.00% <ø> (ø)
...function/arithmetic/vector_arithmetic_operations.h 92.15% <ø> (ø)
src/include/function/built_in_vector_operations.h 100.00% <ø> (ø)
src/include/function/cast/vector_cast_operations.h 91.66% <ø> (ø)
...include/function/struct/vector_struct_operations.h 100.00% <ø> (ø)
src/include/function/vector_operations.h 100.00% <ø> (ø)
src/common/vector/auxiliary_buffer.cpp 90.47% <75.00%> (-9.53%) ⬇️
src/common/types/types.cpp 91.26% <80.00%> (-0.78%) ⬇️
... and 20 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@andyfengHKU andyfengHKU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need one more PR to implement map related functions

src/include/common/expression_type.h Outdated Show resolved Hide resolved
src/include/function/vector_operations.h Outdated Show resolved Hide resolved
@acquamarin acquamarin merged commit 322dab6 into master Jun 8, 2023
8 checks passed
@acquamarin acquamarin deleted the map-literal branch June 8, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants