Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove glob cmake file #1639

Merged
merged 1 commit into from
Jun 6, 2023
Merged

Remove glob cmake file #1639

merged 1 commit into from
Jun 6, 2023

Conversation

ray6080
Copy link
Contributor

@ray6080 ray6080 commented Jun 6, 2023

The use of INTERFACE here in glob requires a pretty high cmake version 3.19.
This PR simplified glob lib to not create an interface library, same as concurrentqueue, nlohmann_json, etc.

@benjaminwinger
Copy link
Collaborator

This line should also be removed if the Glob interface library is being removed.

I think just replacing add_library(Glob INTERFACE glob/glob.hpp) with add_library(Glob INTERFACE) would also be sufficient; I don't think including the headers in an interface library actually provides any benefit other than metadata for certain IDEs (and even then, I think using target_sources(INTERFACE ...) achieves the same thing, and that's been supported since cmake 3.1).

@ray6080
Copy link
Contributor Author

ray6080 commented Jun 6, 2023

This line should also be removed if the Glob interface library is being removed.

I think just replacing add_library(Glob INTERFACE glob/glob.hpp) with add_library(Glob INTERFACE) would also be sufficient; I don't think including the headers in an interface library actually provides any benefit other than metadata for certain IDEs (and even then, I think using target_sources(INTERFACE ...) achieves the same thing, and that's been supported since cmake 3.1).

Sg. I will replace it with add_library(Glob INTERFACE).

@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (cb437d7) 91.66% compared to head (13a5413) 91.66%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1639   +/-   ##
=======================================
  Coverage   91.66%   91.66%           
=======================================
  Files         716      716           
  Lines       26042    26042           
=======================================
  Hits        23871    23871           
  Misses       2171     2171           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ray6080 ray6080 merged commit 3d9ed2e into master Jun 6, 2023
8 checks passed
@ray6080 ray6080 deleted the glob branch June 6, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants