Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serial query processing #1624

Merged
merged 1 commit into from
Jun 4, 2023
Merged

Serial query processing #1624

merged 1 commit into from
Jun 4, 2023

Conversation

acquamarin
Copy link
Collaborator

@acquamarin acquamarin commented Jun 4, 2023

  1. Add comparison/arithmetic/aggregation/order by support for serial dataType.
  2. Fix missing cast/arithmetic operations for struct/internal id types.

@acquamarin acquamarin changed the title Serial query process Serial query processing Jun 4, 2023
@codecov
Copy link

codecov bot commented Jun 4, 2023

Codecov Report

Patch coverage: 89.11% and project coverage change: -0.05 ⚠️

Comparison is base (2e0f617) 91.99% compared to head (6733ec8) 91.95%.

❗ Current head 6733ec8 differs from pull request most recent head 86cfd03. Consider uploading reports for the commit 86cfd03 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1624      +/-   ##
==========================================
- Coverage   91.99%   91.95%   -0.05%     
==========================================
  Files         715      715              
  Lines       26074    26061      -13     
==========================================
- Hits        23987    23964      -23     
- Misses       2087     2097      +10     
Impacted Files Coverage Δ
src/include/common/types/types.h 100.00% <ø> (ø)
src/include/common/vector/value_vector.h 100.00% <ø> (ø)
src/include/function/built_in_vector_operations.h 100.00% <ø> (ø)
...rocessor/operator/aggregate/aggregate_hash_table.h 81.81% <ø> (ø)
src/common/type_utils.cpp 69.30% <66.66%> (+9.51%) ⬆️
...cessor/operator/aggregate/aggregate_hash_table.cpp 80.44% <69.23%> (+1.06%) ⬆️
src/function/vector_cast_operations.cpp 83.06% <87.50%> (+0.33%) ⬆️
src/function/aggregate_function.cpp 81.25% <91.66%> (-1.11%) ⬇️
src/binder/bind/bind_ddl.cpp 100.00% <100.00%> (ø)
src/common/types/types.cpp 91.97% <100.00%> (+0.40%) ⬆️
... and 8 more

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@acquamarin acquamarin force-pushed the serial-query-process branch 2 times, most recently from a0ba3a7 to 87ae57b Compare June 4, 2023 22:09
@acquamarin acquamarin merged commit 23cba0a into master Jun 4, 2023
8 checks passed
@acquamarin acquamarin deleted the serial-query-process branch June 4, 2023 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants