Rework rel copy task scheduling and improve copy performance #1621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ray6080
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1621 +/- ##
==========================================
- Coverage 92.00% 82.18% -9.82%
==========================================
Files 715 716 +1
Lines 26075 26042 -33
==========================================
- Hits 23989 21402 -2587
- Misses 2086 4640 +2554
☔ View full report in Codecov by Sentry. |
acquamarin
approved these changes
Jun 5, 2023
ray6080
commented
Jun 5, 2023
| : copyDescription{copyDescription}, outputDirectory{std::move(outputDirectory)}, | ||
| taskScheduler{taskScheduler}, catalog{catalog}, | ||
| tableSchema{catalog.getReadOnlyVersion()->getTableSchema(table->getTableID())}, | ||
| table{table}, nodesStatisticsAndDeletedIDs{nodesStatisticsAndDeletedIDs}, numRows{0} {} |
There was a problem hiding this comment.
Unify the term usage of row and tuple. I would prefer tuple.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major changes:
NodeCopyExecutorandRelCopyExecutor. These two no longer extend from a base class.TableCopyExecutoris turned into a utils classTableCopyUtils.NodeCopier, which further simplifiesNodeCopyExecutor.On my local laptop (M1 macbook air, 16GB RAM, 8 threads, default setting), the performance boost on copying ldbc10 knows and likesComment compared to v0.0.3 are: