Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spdlog header resolution #1620

Merged
merged 1 commit into from
Jun 4, 2023
Merged

Fix spdlog header resolution #1620

merged 1 commit into from
Jun 4, 2023

Conversation

mewim
Copy link
Member

@mewim mewim commented Jun 4, 2023

No description provided.

@mewim mewim force-pushed the spdlog-header-resolution branch from b4d614e to 8fa2c92 Compare June 4, 2023 03:48
@mewim mewim force-pushed the spdlog-header-resolution branch from 8fa2c92 to 7f89c90 Compare June 4, 2023 04:14
@codecov
Copy link

codecov bot commented Jun 4, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (2e0f617) 91.99% compared to head (7f89c90) 92.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1620   +/-   ##
=======================================
  Coverage   91.99%   92.00%           
=======================================
  Files         715      715           
  Lines       26074    26075    +1     
=======================================
+ Hits        23987    23989    +2     
+ Misses       2087     2086    -1     
Impacted Files Coverage Δ
src/function/vector_struct_operations.cpp 92.72% <ø> (ø)
src/include/common/types/types.h 100.00% <ø> (ø)
src/include/storage/copier/node_copy_executor.h 100.00% <ø> (ø)
src/storage/buffer_manager/vm_region.cpp 75.00% <ø> (ø)
...e/in_mem_storage_structure/in_mem_column_chunk.cpp 80.26% <ø> (ø)
src/common/types/types.cpp 91.69% <100.00%> (+0.12%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mewim mewim merged commit 2369fa8 into master Jun 4, 2023
8 checks passed
@mewim mewim deleted the spdlog-header-resolution branch June 4, 2023 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants