value refactor #1614
Merged
value refactor #1614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyfengHKU
approved these changes
Jun 3, 2023
| @@ -179,8 +179,11 @@ void Binder::bindQueryRel(const RelPattern& relPattern, | |||
| " are not connected through rel " + parsedName + "."); | |||
| } | |||
| } | |||
| auto dataType = isVariableLength ? common::LogicalType(common::LogicalTypeID::RECURSIVE_REL) : | |||
| common::LogicalType(common::LogicalTypeID::REL); | |||
| auto dataType = isVariableLength ? | |||
There was a problem hiding this comment.
Can u check other places where we switch for RECURSIVE_REL logical type. We should propogate child type to those places as well.
For example
AuxiliaryBufferFactory::getAuxiliaryBuffer
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1614 +/- ##
==========================================
- Coverage 91.95% 91.94% -0.02%
==========================================
Files 705 705
Lines 25654 25637 -17
==========================================
- Hits 23591 23571 -20
- Misses 2063 2066 +3
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the storage of value to store the physical dataType only.