Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node js binding rework #1613

Merged
merged 1 commit into from
Jun 3, 2023
Merged

Node js binding rework #1613

merged 1 commit into from
Jun 3, 2023

Conversation

mewim
Copy link
Member

@mewim mewim commented Jun 2, 2023

No description provided.

@mewim mewim closed this Jun 2, 2023
@mewim mewim reopened this Jun 2, 2023
@ray6080 ray6080 marked this pull request as ready for review June 2, 2023 23:59
@codecov
Copy link

codecov bot commented Jun 3, 2023

Codecov Report

Patch coverage: 90.57% and project coverage change: -0.02 ⚠️

Comparison is base (48dfd1b) 91.95% compared to head (3f7f00d) 91.94%.

❗ Current head 3f7f00d differs from pull request most recent head 0b86edf. Consider uploading reports for the commit 0b86edf to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1613      +/-   ##
==========================================
- Coverage   91.95%   91.94%   -0.02%     
==========================================
  Files         705      715      +10     
  Lines       25654    26074     +420     
==========================================
+ Hits        23591    23974     +383     
- Misses       2063     2100      +37     
Impacted Files Coverage Δ
src/include/main/prepared_statement.h 100.00% <ø> (ø)
tools/nodejs_api/src_cpp/include/node_database.h 77.77% <75.00%> (ø)
...dejs_api/src_cpp/include/node_prepared_statement.h 77.77% <77.77%> (ø)
tools/nodejs_api/src_cpp/node_query_result.cpp 84.78% <80.00%> (ø)
...ols/nodejs_api/src_cpp/include/node_query_result.h 84.09% <84.09%> (ø)
tools/nodejs_api/src_cpp/node_connection.cpp 89.04% <88.70%> (ø)
tools/nodejs_api/src_cpp/include/node_connection.h 88.88% <88.88%> (ø)
tools/nodejs_api/src_cpp/node_util.cpp 94.30% <94.30%> (ø)
tools/nodejs_api/src_cpp/main.cpp 100.00% <100.00%> (ø)
tools/nodejs_api/src_cpp/node_database.cpp 100.00% <100.00%> (ø)
... and 1 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mewim mewim merged commit 53a6ca9 into master Jun 3, 2023
4 checks passed
@mewim mewim deleted the node-js-binding-rework branch June 3, 2023 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants