-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test Framework: Support CSV to Parquet conversion #1611
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
ed1886d
Test Framework: Support CSV to Parquet conversion
rfdavid 9978544
Added parquet tinysnb test and parser adjustments
rfdavid c50eca8
Added CSV param to the newly created tests
rfdavid 81f03c1
Fixes from code review #1611
rfdavid 8bfaf67
Rebase
rfdavid b8efcb5
Change to FileUtils::joinPath
rfdavid 19e8077
Remove joinPath from createCopyCommandInfo
rfdavid File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
#include "main/kuzu.h" | ||
#include <arrow/api.h> | ||
|
||
namespace kuzu { | ||
namespace testing { | ||
|
||
// Convert an entire CSV dataset directory to parquet. | ||
// The dataset directory must contain schema and copy files. | ||
class CSVToParquetConverter { | ||
public: | ||
static void convertCSVDatasetToParquet(std::string& dataset); | ||
|
||
private: | ||
struct CopyCommandInfo { | ||
std::string table; | ||
std::string csvFilePath; | ||
std::string parquetFilePath; | ||
bool csvHasHeader; | ||
char delimiter; | ||
}; | ||
|
||
static std::vector<CopyCommandInfo> readCopyCommandsFromCopyCypherFile( | ||
const std::string& dataset); | ||
|
||
static void convertCSVFilesToParquet( | ||
const std::vector<CSVToParquetConverter::CopyCommandInfo>& copyCommands); | ||
|
||
static CopyCommandInfo createCopyCommandInfo( | ||
const std::string& dataset, std::string copyStatement); | ||
|
||
static arrow::Status runCSVToParquetConversion(const std::string& inputFile, | ||
const std::string& outputFile, char delimiter, bool hasHeader); | ||
|
||
static void copySchema( | ||
const std::string& csvDatasetPath, const std::string& parquetDatasetPath); | ||
|
||
static void createCopyFile(const std::string& dataset, | ||
const std::vector<CSVToParquetConverter::CopyCommandInfo>& copyCommands); | ||
|
||
inline static std::string replaceSlashesWithUnderscores(std::string dataset) { | ||
std::replace(dataset.begin(), dataset.end(), '/', '_'); | ||
return dataset; | ||
} | ||
|
||
static std::string extractPath(std::string& str, char delimiter); | ||
}; | ||
|
||
} // namespace testing | ||
} // namespace kuzu |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
-GROUP CopyNodeFromCSVTest | ||
-DATASET copy-test/node/csv | ||
-DATASET CSV copy-test/node/csv | ||
|
||
-- | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
-GROUP CopyNodeFromParquetTest | ||
-DATASET copy-test/node/parquet | ||
-DATASET CSV copy-test/node/parquet | ||
|
||
-- | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
-GROUP DemoDBTest | ||
-DATASET demo-db/csv | ||
-DATASET CSV demo-db/csv | ||
|
||
-- | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
-GROUP DemoDBCreateTest | ||
-DATASET demo-db/csv | ||
-DATASET CSV demo-db/csv | ||
|
||
-- | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
-GROUP DemoDBDeleteTest | ||
-DATASET demo-db/csv | ||
-DATASET CSV demo-db/csv | ||
|
||
-- | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
-GROUP DemoDBTest | ||
-DATASET demo-db/csv | ||
-DATASET CSV demo-db/csv | ||
|
||
-- | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
-GROUP DemoDBTest | ||
-DATASET demo-db/parquet | ||
-DATASET PARQUET demo-db/parquet | ||
|
||
-- | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
-GROUP DemoDBTest | ||
-DATASET demo-db/parquet | ||
-DATASET PARQUET demo-db/parquet | ||
|
||
-- | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
-GROUP DemoDBSetAndCopyTest | ||
-DATASET demo-db/csv | ||
-DATASET CSV demo-db/csv | ||
|
||
-- | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
-GROUP BinderErrorTest | ||
-DATASET tinysnb | ||
-DATASET CSV tinysnb | ||
|
||
-- | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
-GROUP CatalogErrorTest | ||
-DATASET tinysnb | ||
-DATASET CSV tinysnb | ||
|
||
-- | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
-GROUP SyntaxErrorTest | ||
-DATASET dummy | ||
-DATASET CSV dummy | ||
|
||
-- | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
-GROUP SyntaxErrorTest | ||
-DATASET dummy | ||
-DATASET CSV dummy | ||
|
||
-- | ||
|
||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to call
FileUtils::joinPath
to concatenation file paths?Also in
appendKuzuRootPath
.