Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add update to table with serial #1610

Merged
merged 1 commit into from
Jun 3, 2023
Merged

add update to table with serial #1610

merged 1 commit into from
Jun 3, 2023

Conversation

acquamarin
Copy link
Collaborator

@acquamarin acquamarin commented Jun 2, 2023

Add support to update table with SERIAL as primary key.

@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04 🎉

Comparison is base (48dfd1b) 91.95% compared to head (aeb8569) 92.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1610      +/-   ##
==========================================
+ Coverage   91.95%   92.00%   +0.04%     
==========================================
  Files         705      715      +10     
  Lines       25654    26067     +413     
==========================================
+ Hits        23591    23982     +391     
- Misses       2063     2085      +22     
Impacted Files Coverage Δ
src/common/types/types.cpp 91.47% <ø> (ø)
src/include/storage/store/node_table.h 100.00% <ø> (ø)
src/binder/bind/bind_updating_clause.cpp 95.53% <100.00%> (ø)
src/common/types/value.cpp 92.03% <100.00%> (-0.62%) ⬇️
src/include/processor/operator/update/create.h 100.00% <100.00%> (ø)
src/optimizer/projection_push_down_optimizer.cpp 99.20% <100.00%> (+<0.01%) ⬆️
src/processor/mapper/map_create.cpp 100.00% <100.00%> (ø)
src/processor/operator/update/create.cpp 100.00% <100.00%> (ø)
src/storage/store/node_table.cpp 100.00% <100.00%> (ø)

... and 20 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

src/storage/store/node_table.cpp Show resolved Hide resolved
@acquamarin acquamarin merged commit ae9ac90 into master Jun 3, 2023
8 checks passed
@acquamarin acquamarin deleted the update-serial branch June 3, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants