Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix struct parsing #1609

Merged
merged 1 commit into from
Jun 3, 2023
Merged

Fix struct parsing #1609

merged 1 commit into from
Jun 3, 2023

Conversation

andyfengHKU
Copy link
Contributor

@andyfengHKU andyfengHKU commented Jun 2, 2023

This PR fixes

  • parsing struct with quoted key e.g. {"a": 1}
  • group out of bound for regex functions
  • print STRUCT type as STRUCT(KEY:DATATYPE...) instead of. STRUCT(DATATYPE...)

@codecov
Copy link

codecov bot commented Jun 3, 2023

Codecov Report

Patch coverage: 91.89% and project coverage change: -0.01 ⚠️

Comparison is base (657623b) 91.94% compared to head (d51e2b5) 91.94%.

❗ Current head d51e2b5 differs from pull request most recent head 1a10e07. Consider uploading reports for the commit 1a10e07 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1609      +/-   ##
==========================================
- Coverage   91.94%   91.94%   -0.01%     
==========================================
  Files         715      715              
  Lines       26057    26064       +7     
==========================================
+ Hits        23959    23964       +5     
- Misses       2098     2100       +2     
Impacted Files Coverage Δ
src/common/types/value.cpp 92.03% <ø> (ø)
src/storage/storage_structure/column.cpp 91.42% <ø> (ø)
src/storage/wal_replayer_utils.cpp 98.52% <ø> (ø)
tools/nodejs_api/src_cpp/node_util.cpp 94.30% <ø> (ø)
tools/python_api/src_cpp/py_query_result.cpp 97.05% <ø> (ø)
src/parser/transformer.cpp 95.79% <75.00%> (-0.15%) ⬇️
...e/in_mem_storage_structure/in_mem_column_chunk.cpp 80.26% <80.00%> (ø)
src/c_api/value.cpp 100.00% <100.00%> (ø)
src/common/types/types.cpp 91.56% <100.00%> (+0.09%) ⬆️
src/common/vector/auxiliary_buffer.cpp 100.00% <100.00%> (ø)
... and 8 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@andyfengHKU andyfengHKU merged commit 5063785 into master Jun 3, 2023
8 checks passed
@andyfengHKU andyfengHKU deleted the struct-fix branch June 3, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants