Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option -SKIP to skip test cases #1603

Merged
merged 2 commits into from
Jun 1, 2023
Merged

Conversation

rfdavid
Copy link
Collaborator

@rfdavid rfdavid commented May 31, 2023

This PR implements -SKIP capability to be added in the test header or an individual test case. It follows the GTest framework by adding the prefix DISABLED_ above the test name.

Example:

# To skip the whole file, add -SKIP in any place after -GROUP and before the end of the header --
-GROUP TinySnbUpdateTest
-DATASET tinysnb
-SKIP

# or to skip test cases individually, add -SKIP below -CASE

-CASE SetNodeListOfLongStringPropTest
-SKIP
-STATEMENT MATCH (a:person) WHERE a.ID=0 SET a.usedNames=['abcndwjbwesdsd','microsofthbbjuwgedsd']
---- ok
-QUERY MATCH (a:person) WHERE a.ID=0 RETURN a.usedNames
---- 1
[abcndwjbwesdsd,microsofthbbjuwgedsd]

Will be shown in the test report:

...
527/686 Test #527: TinySnbUpdateTest.SetNodeListofListPropTest .....................................................................***Not Run (Disabled)   0.00 sec
...
100% tests passed, 0 tests failed out of 680

Total Test time (real) = 136.72 sec

The following tests did not run:
	490 - TinySnbUpdateTest.InsertNodeWithListTest (Disabled)
	505 - TinySnbUpdateTest.SetNodeListOfLongStringPropTest (Disabled)
	506 - TinySnbUpdateTest.SetNodeListOfShortStringPropTest (Disabled)
	508 - TinySnbUpdateTest.SetNodeListOfIntPropTest (Disabled)
	527 - TinySnbUpdateTest.SetNodeListofListPropTest (Disabled)

@rfdavid rfdavid requested a review from ray6080 May 31, 2023 20:00
@rfdavid rfdavid changed the title Add option to -SKIP test cases Add option -SKIP to skip test cases May 31, 2023
@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (e3fff3a) 91.93% compared to head (b723cf8) 91.93%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1603   +/-   ##
=======================================
  Coverage   91.93%   91.93%           
=======================================
  Files         704      704           
  Lines       25567    25567           
=======================================
  Hits        23504    23504           
  Misses       2063     2063           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@@ -29,7 +29,8 @@ enum class TokenType {
RESULT,
SEPARATOR,
STATEMENT,
STATEMENT_BLOCK
STATEMENT_BLOCK,
_SKIP
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed, rename _SKIP to SKIP_LINE.

@rfdavid rfdavid merged commit 317c032 into kuzudb:master Jun 1, 2023
8 checks passed
@rfdavid rfdavid deleted the skip_tests branch June 1, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants