Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print error details on test failure #1598

Merged
merged 1 commit into from
May 31, 2023
Merged

Conversation

rfdavid
Copy link
Collaborator

@rfdavid rfdavid commented May 31, 2023

This is a simple suggestion to add --output-on-failure on ctest so when a test fails we can see the detailed information. This might be useful, especially for the CI output.

@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (8bbec69) 91.93% compared to head (b31aea3) 91.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1598      +/-   ##
==========================================
- Coverage   91.93%   91.92%   -0.01%     
==========================================
  Files         703      703              
  Lines       25545    25545              
==========================================
- Hits        23484    23482       -2     
- Misses       2061     2063       +2     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rfdavid rfdavid merged commit e3fff3a into kuzudb:master May 31, 2023
8 checks passed
@rfdavid rfdavid deleted the makefile_changes branch May 31, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants