-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert e2e_update_node.cpp to e2e test files #1597
Conversation
* Convert e2e_update_node_test to create.test, delete.test and set.test * Adds -DEFINE variable anyValue * Adds -DEFINE ARANGE 0 4 to generate [0,1,2,3,4] * Deletes e2e_update_node_test
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #1597 +/- ##
==========================================
+ Coverage 91.91% 91.92% +0.01%
==========================================
Files 703 703
Lines 25544 25545 +1
==========================================
+ Hits 23479 23483 +4
+ Misses 2065 2062 -3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Can you add commented tests to the test file (skipped or commented) too? I'm afraid we will forget these tests later when we turn them on.
- Let's discuss the
DEFINE
syntax a bit more, I hope it can be more formally defined and we can extend it later. for example,-DEFINE R_EXCEPTION Runtime exception:
is not a clear syntax to me. It should be something along-DEFINE R_EXCEPTION "Runtime exception: "
, or-DEFINE R_EXCEPTION STRING("Runtime exception: ")
, so its data type is clear. I feel like this is important and we should think a bit more on this.
|
||
-- | ||
|
||
-CASE DeleteNodeAfterInsertTest) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove ")".
One feedback, though not related to this PR, is that when a test cases contain multiple test units (each identified by a NAME), is there a way that we can print which test unit fails in the log? Currently I believe we only report which test case fails, but it's unclear where the test case breaks. |
This PR performs the following:
e2e_update_node.cpp
intotinysnb/update_node/create.test
,tinysnb/update_node/delete.test
andtinysnb/update_node/set.test
.-DEFINE
to create variablesARANGE start end
to create listsExample: