Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LDBC interactive short queries to test #1589

Merged
merged 1 commit into from
May 30, 2023
Merged

Add LDBC interactive short queries to test #1589

merged 1 commit into from
May 30, 2023

Conversation

aziz-mu
Copy link
Contributor

@aziz-mu aziz-mu commented May 29, 2023

Adding the LDBC sf0.1 dataset, as well as 5/7 tests of the SNB Interactive short tests.

  • Dataset is about 65 MB
  • Interactive short queries 2 and 6 were removed due to having [REPLY_OF*0..] , which isn't possible to do currently.
  • In query 4, the coalesce() function available in Neo4J was replaced with a CASE WHEN statement, since it only has 2 arguments the expected behaviour stays the same
  • Arbitrary IDs that existed in the database were chosen for the queries. Query ref can be found at https://github.com/ldbc/ldbc_snb_interactive_impls/tree/main/cypher/queries
  • All results were validated using Neo4J

@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (2478bc8) 91.93% compared to head (074c082) 91.92%.

❗ Current head 074c082 differs from pull request most recent head 7efbc98. Consider uploading reports for the commit 7efbc98 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1589      +/-   ##
==========================================
- Coverage   91.93%   91.92%   -0.01%     
==========================================
  Files         703      703              
  Lines       25339    25545     +206     
==========================================
+ Hits        23295    23483     +188     
- Misses       2044     2062      +18     

see 31 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aziz-mu aziz-mu requested review from ray6080 and andyfengHKU and removed request for ray6080 May 29, 2023 21:19
@aziz-mu aziz-mu merged commit 127e6d9 into master May 30, 2023
8 checks passed
@aziz-mu aziz-mu deleted the ldbc-test branch May 30, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants