Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GetFileSizeEX instead of GetFileSize on windows #1587

Merged
merged 1 commit into from
May 31, 2023

Conversation

benjaminwinger
Copy link
Collaborator

Following up #1573 (comment). I also added error handling.

@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (2478bc8) 91.93% compared to head (991c54c) 91.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1587      +/-   ##
==========================================
- Coverage   91.93%   91.92%   -0.01%     
==========================================
  Files         703      703              
  Lines       25339    25339              
==========================================
- Hits        23295    23293       -2     
- Misses       2044     2046       +2     
Impacted Files Coverage Δ
src/common/file_utils.cpp 71.60% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@benjaminwinger
Copy link
Collaborator Author

LARGE_INTEGER with QuadPart seems to be windows 10+ only. I think the LowPart/HighPart version was used on older versions of windows (OLD_LARGE_INTEGER).

I think everything prior to this works on versions as old as windows XP (at least, the windows APIs anyway).

@andyfengHKU andyfengHKU merged commit ca8ba4b into master May 31, 2023
8 checks passed
@andyfengHKU andyfengHKU deleted the windows-file-size branch May 31, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants