Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix return functor windows compatibility #1586

Merged
merged 1 commit into from
May 29, 2023

Conversation

andyfengHKU
Copy link
Contributor

Windows doesn't have a good support to return function pointer. Previously we had to expose static functions in header files in order to return their pointer.

This PR changes return function pointer to set a functor reference. So we can wrap static functions inside class.

@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Patch coverage: 95.57% and project coverage change: -0.03 ⚠️

Comparison is base (2478bc8) 91.93% compared to head (d0dcbd5) 91.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1586      +/-   ##
==========================================
- Coverage   91.93%   91.91%   -0.03%     
==========================================
  Files         703      703              
  Lines       25339    25515     +176     
==========================================
+ Hits        23295    23451     +156     
- Misses       2044     2064      +20     
Impacted Files Coverage Δ
...ude/function/interval/vector_interval_operations.h 95.45% <ø> (ø)
...include/function/string/vector_string_operations.h 96.00% <ø> (ø)
...cessor/operator/aggregate/aggregate_hash_table.cpp 79.37% <60.00%> (-1.79%) ⬇️
src/function/vector_cast_operations.cpp 82.72% <88.23%> (-0.11%) ⬇️
...binder/bind_expression/bind_boolean_expression.cpp 100.00% <100.00%> (ø)
.../bind_expression/bind_null_operator_expression.cpp 100.00% <100.00%> (ø)
src/binder/expression_binder.cpp 97.33% <100.00%> (+0.03%) ⬆️
src/function/vector_boolean_operations.cpp 79.31% <100.00%> (+7.88%) ⬆️
src/function/vector_list_operation.cpp 89.89% <100.00%> (+0.22%) ⬆️
src/function/vector_null_operations.cpp 72.72% <100.00%> (+10.22%) ⬆️
... and 11 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@andyfengHKU andyfengHKU merged commit 75a0bef into master May 29, 2023
8 checks passed
@andyfengHKU andyfengHKU deleted the win-vector-operations-fix branch May 29, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants