Don't always set GENERIC_READ when opening files on windows #1585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #1585 +/- ##
==========================================
- Coverage 91.93% 91.92% -0.02%
==========================================
Files 703 703
Lines 25339 25339
==========================================
- Hits 23295 23292 -3
- Misses 2044 2047 +3
☔ View full report in Codecov by Sentry. |
benjaminwinger
force-pushed
the
windows-file-access-mode
branch
from
78c67fb
to
171f404
Compare
acquamarin
approved these changes
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up #1573 (comment).
It turns out the problems I ran into the first time were due to a logic error. I was reading the Windows docs for
_open, which, unlike the corresponding Linux docs, don't mention thatO_RDONLYis0.