Convert e2e_exception_test to end to end test #1584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfdavid
changed the title
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #1584 +/- ##
==========================================
- Coverage 91.91% 91.91% -0.01%
==========================================
Files 703 703
Lines 25543 25544 +1
==========================================
Hits 23479 23479
- Misses 2064 2065 +1
☔ View full report in Codecov by Sentry. |
ray6080
approved these changes
May 30, 2023
test/runner/e2e_read_test.cpp
Outdated
| @@ -45,6 +45,8 @@ void parseAndRegisterTestGroup(const std::string& path) { | |||
| return new EndToEndReadTest(dataset, bufferPoolSize, std::move(testStatements)); | |||
| }); | |||
| } | |||
| } else { | |||
| throw Exception("Invalid test file"); | |||
There was a problem hiding this comment.
Can you add the file path into the exception here?
Also, I would add a TestException class and throw TestException here. See common/exception.h.
* Added -BEGIN_WRITE_TRANSACTION * Split exception.test into multiple files * Raise exception when test file is invalid * Removed cpp exception file
rfdavid
force-pushed
the
convert_exception_test
branch
from
cb0fb6d
to
64ce7fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the following:
-BEGIN_WRITE_TRANSACTIONwithin the test fileexception.testinto multiple filese2e_exception_test.cppfile