Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi label recursive join #1581

Merged
merged 1 commit into from
May 31, 2023
Merged

Multi label recursive join #1581

merged 1 commit into from
May 31, 2023

Conversation

andyfengHKU
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented May 28, 2023

Codecov Report

Patch coverage: 99.10% and no project coverage change.

Comparison is base (8bbec69) 91.93% compared to head (c2f85e2) 91.93%.

❗ Current head c2f85e2 differs from pull request most recent head e9ea91b. Consider uploading reports for the commit e9ea91b to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #1581    +/-   ##
========================================
  Coverage   91.93%   91.93%            
========================================
  Files         703      704     +1     
  Lines       25545    25361   -184     
========================================
- Hits        23484    23316   -168     
+ Misses       2061     2045    -16     
Impacted Files Coverage Δ
src/include/binder/binder.h 100.00% <ø> (ø)
src/include/planner/join_order_enumerator.h 100.00% <ø> (ø)
src/binder/bind/bind_graph_pattern.cpp 94.28% <88.23%> (+0.38%) ⬆️
...inder/bind_expression/bind_function_expression.cpp 96.24% <100.00%> (ø)
src/binder/visitor/property_collector.cpp 98.11% <100.00%> (+0.03%) ⬆️
src/include/binder/expression/rel_expression.h 100.00% <100.00%> (ø)
src/include/processor/operator/mask.h 100.00% <100.00%> (ø)
...de/processor/operator/recursive_extend/bfs_state.h 100.00% <100.00%> (ø)
...ude/processor/operator/recursive_extend/frontier.h 100.00% <100.00%> (ø)
...processor/operator/recursive_extend/path_scanner.h 100.00% <100.00%> (ø)
... and 16 more

... and 29 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@ray6080 ray6080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One general comment is that we should clean up the use of struct and use class when necessary. e.g., BaseFrontierScanner, Frontier, etc.

@andyfengHKU andyfengHKU merged commit c99ba3b into master May 31, 2023
@andyfengHKU andyfengHKU deleted the multi-label-recursive-join branch May 31, 2023 17:30
@andyfengHKU andyfengHKU restored the multi-label-recursive-join branch July 17, 2023 01:20
@andyfengHKU andyfengHKU deleted the multi-label-recursive-join branch July 17, 2023 01:21
@andyfengHKU andyfengHKU restored the multi-label-recursive-join branch July 17, 2023 02:33
@andyfengHKU andyfengHKU deleted the multi-label-recursive-join branch July 19, 2023 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants