Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert lsqb cpp tests to end to end tests #1580

Merged
merged 1 commit into from
May 29, 2023

Conversation

rfdavid
Copy link
Collaborator

@rfdavid rfdavid commented May 28, 2023

This PR converts LSQB tests to end-to-end tests by adding support to define buffer pool size inside the test file header. Example:

lsqb.test:

-GROUP LSQBTest
-DATASET sf-0.1
-BUFFER_POOL_SIZE 1073741824

--

-CASE LSQBTest
...

For number 1073741824 was calculated based on the actual code:

constants.h:
static constexpr uint64_t DEFAULT_BUFFER_POOL_SIZE_FOR_TESTING = 1ull << 26; // 67108864

lsqb.cpp:
systemConfig->bufferPoolSize = kuzu::common::BufferPoolConstants::DEFAULT_BUFFER_POOL_SIZE_FOR_TESTING * 16;

Hence 67108864*16 = 1073741824

@rfdavid rfdavid requested a review from ray6080 May 28, 2023 10:45
@codecov
Copy link

codecov bot commented May 28, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (fbee1f6) 91.86% compared to head (d9b8d3b) 91.87%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1580   +/-   ##
=======================================
  Coverage   91.86%   91.87%           
=======================================
  Files         701      701           
  Lines       25325    25325           
=======================================
+ Hits        23266    23267    +1     
+ Misses       2059     2058    -1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rfdavid rfdavid merged commit 2478bc8 into kuzudb:master May 29, 2023
8 checks passed
@rfdavid rfdavid deleted the convert_lsqb_test_to_e2e branch May 29, 2023 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants