Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert demo db tests to e2e tests #1574

Merged
merged 4 commits into from
May 28, 2023

Conversation

rfdavid
Copy link
Collaborator

@rfdavid rfdavid commented May 26, 2023

This PR replaces demo_db_test.cpp by end to end test. It also enables using ${KUZU_ROOT_DIRECTORY} inside .test on query or result lines:

Example:

-QUERY COPY Follows FROM "${KUZU_ROOT_DIRECTORY}/dataset/demo-db/csv/follows.csv"
---- error
Copy exception: COPY commands can only be executed once on a table.

@rfdavid rfdavid requested a review from ray6080 May 26, 2023 17:33
@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (da75c9d) 91.86% compared to head (47426ad) 91.86%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1574   +/-   ##
=======================================
  Coverage   91.86%   91.86%           
=======================================
  Files         701      701           
  Lines       25321    25325    +4     
=======================================
+ Hits        23262    23266    +4     
  Misses       2059     2059           
Impacted Files Coverage Δ
src/include/common/string_utils.h 100.00% <ø> (ø)
src/common/string_utils.cpp 71.42% <100.00%> (+6.72%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rfdavid rfdavid force-pushed the convert_demo_db_tests_to_e2e_tests branch from f2750c7 to 7de88e1 Compare May 27, 2023 11:20
@rfdavid rfdavid force-pushed the convert_demo_db_tests_to_e2e_tests branch from c67a04f to 47426ad Compare May 28, 2023 00:56
@rfdavid rfdavid merged commit fbee1f6 into kuzudb:master May 28, 2023
8 checks passed
@rfdavid rfdavid deleted the convert_demo_db_tests_to_e2e_tests branch May 28, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants