NPY loader fix #1571
Merged
NPY loader fix #1571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1571 +/- ##
==========================================
+ Coverage 91.91% 91.97% +0.05%
==========================================
Files 703 701 -2
Lines 25515 25235 -280
==========================================
- Hits 23453 23210 -243
+ Misses 2062 2025 -37
☔ View full report in Codecov by Sentry. |
ray6080
approved these changes
May 29, 2023
|
|
||
| void flush(common::FileInfo* walFileInfo) override; | ||
|
|
||
| common::offset_t getOffsetInBuffer(common::offset_t pos) override; |
There was a problem hiding this comment.
Does this function need to be public?
ray6080
approved these changes
May 29, 2023
acquamarin
force-pushed
the
npy-loader-fix
branch
from
948d2c0
to
ca14982
Compare
acquamarin
force-pushed
the
npy-loader-fix
branch
from
ca14982
to
a08d9e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NPY Loader Fix
BUG: A problem arises when the tensor's size isn't a power of 2. The tensor may end up being stored across two pages, leading to inconsistencies when retrieving data from these pages.
Solution: During the process of writing tensors to the InMemColumnChunk, we now compute the page index and offset for each tensor. This calculated position allows us to avoid storing a tensor accross two pages.