Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert binder error tests to end to end tests #1569

Merged
merged 2 commits into from
May 25, 2023

Conversation

rfdavid
Copy link
Collaborator

@rfdavid rfdavid commented May 25, 2023

This PR converts test/binder/binder_error_test.cpp to end-to-end test file.

@rfdavid rfdavid requested a review from ray6080 May 25, 2023 01:31
@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Patch coverage: 88.33% and project coverage change: -0.04 ⚠️

Comparison is base (c08468f) 92.00% compared to head (2d5a521) 91.97%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1569      +/-   ##
==========================================
- Coverage   92.00%   91.97%   -0.04%     
==========================================
  Files         700      701       +1     
  Lines       25116    25208      +92     
==========================================
+ Hits        23109    23184      +75     
- Misses       2007     2024      +17     
Impacted Files Coverage Δ
src/include/common/types/types.h 100.00% <ø> (ø)
src/include/storage/storage_utils.h 100.00% <ø> (ø)
src/include/storage/wal_replayer_utils.h 100.00% <ø> (ø)
...e/in_mem_storage_structure/in_mem_column_chunk.cpp 79.29% <80.81%> (-1.48%) ⬇️
src/common/types/types.cpp 91.47% <97.01%> (+0.39%) ⬆️
src/include/common/string_utils.h 100.00% <100.00%> (ø)
src/include/storage/copier/node_copier.h 93.54% <100.00%> (-0.21%) ⬇️
...e/storage/in_mem_storage_structure/in_mem_column.h 100.00% <100.00%> (ø)
...age/in_mem_storage_structure/in_mem_column_chunk.h 100.00% <100.00%> (ø)
src/storage/copier/node_copier.cpp 98.31% <100.00%> (+6.76%) ⬆️
... and 5 more

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Binder exception: Bind relationship e1 to relationship with same name is not supported.


-CASE RepeatedReturnColumnName)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the ")" at the end.

@rfdavid rfdavid merged commit 58c92ee into kuzudb:master May 25, 2023
@rfdavid rfdavid deleted the binder_test branch May 25, 2023 04:11
benjaminwinger pushed a commit to benjaminwinger/kuzu that referenced this pull request May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants