Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable multiple test cases inside one test file #1567

Merged
merged 2 commits into from
May 24, 2023

Conversation

rfdavid
Copy link
Collaborator

@rfdavid rfdavid commented May 24, 2023

This enables using multiple -CASE inside the same test file, so GoogleTest registers multiple test cases based on this parameter.

This enables using multiple -CASE inside the same test file
so GoogleTest registers multiple test cases based on this
parameter.
@rfdavid rfdavid requested a review from ray6080 May 24, 2023 16:16
@rfdavid rfdavid self-assigned this May 24, 2023
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.15 🎉

Comparison is base (91204de) 91.73% compared to head (9395a30) 91.88%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1567      +/-   ##
==========================================
+ Coverage   91.73%   91.88%   +0.15%     
==========================================
  Files         698      700       +2     
  Lines       25128    25116      -12     
==========================================
+ Hits        23050    23079      +29     
+ Misses       2078     2037      -41     

see 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

test/include/test_runner/test_group.h Outdated Show resolved Hide resolved
test/test_runner/test_parser.cpp Outdated Show resolved Hide resolved
test/test_runner/test_parser.cpp Outdated Show resolved Hide resolved
@rfdavid rfdavid merged commit acf2ba6 into kuzudb:master May 24, 2023
7 checks passed
@rfdavid rfdavid deleted the convert_to_end2end_tests branch May 24, 2023 18:47
benjaminwinger pushed a commit to benjaminwinger/kuzu that referenced this pull request May 26, 2023
This implementation enables using multiple -CASE inside the same test file
so GoogleTest registers multiple test cases based on this
parameter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants