Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loader support for struct of list/struct/string #1563

Merged
merged 1 commit into from
May 24, 2023

Conversation

acquamarin
Copy link
Collaborator

@acquamarin acquamarin commented May 24, 2023

  1. This PR adds loader support for struct of list/struct/string.
  2. Refactors the InMemColumnChunk using a hierachy structure.

@ray6080 ray6080 self-requested a review May 24, 2023 03:47
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@6936d8d). Click here to learn what that means.
Patch coverage: 87.87% of modified lines in pull request are covered.

❗ Current head 7c25d12 differs from pull request most recent head 3ae8639. Consider uploading reports for the commit 3ae8639 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1563   +/-   ##
=========================================
  Coverage          ?   91.68%           
=========================================
  Files             ?      699           
  Lines             ?    25218           
  Branches          ?        0           
=========================================
  Hits              ?    23121           
  Misses            ?     2097           
  Partials          ?        0           
Impacted Files Coverage Δ
src/include/common/types/types.h 100.00% <ø> (ø)
src/include/storage/storage_utils.h 100.00% <ø> (ø)
src/include/storage/wal_replayer_utils.h 100.00% <ø> (ø)
...e/in_mem_storage_structure/in_mem_column_chunk.cpp 79.29% <80.81%> (ø)
...age/in_mem_storage_structure/in_mem_column_chunk.h 93.33% <87.50%> (ø)
src/common/types/types.cpp 91.47% <97.01%> (ø)
src/include/common/string_utils.h 100.00% <100.00%> (ø)
src/include/storage/copier/node_copier.h 93.54% <100.00%> (ø)
...e/storage/in_mem_storage_structure/in_mem_column.h 100.00% <100.00%> (ø)
src/storage/copier/node_copier.cpp 98.29% <100.00%> (ø)
... and 5 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

src/storage/wal_replayer_utils.cpp Outdated Show resolved Hide resolved
src/storage/wal_replayer_utils.cpp Outdated Show resolved Hide resolved
src/storage/storage_utils.cpp Outdated Show resolved Hide resolved
@acquamarin acquamarin merged commit 122d68f into master May 24, 2023
7 checks passed
@acquamarin acquamarin deleted the struct-of-list branch May 24, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants