Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check statement read only through visitor pattern #1559

Merged
merged 1 commit into from
May 24, 2023

Conversation

andyfengHKU
Copy link
Contributor

No description provided.

@andyfengHKU andyfengHKU requested a review from ray6080 May 21, 2023 18:21
@codecov
Copy link

codecov bot commented May 21, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.16 🎉

Comparison is base (43e0393) 91.72% compared to head (b003493) 91.88%.

❗ Current head b003493 differs from pull request most recent head 0b076bc. Consider uploading reports for the commit 0b076bc to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1559      +/-   ##
==========================================
+ Coverage   91.72%   91.88%   +0.16%     
==========================================
  Files         698      697       -1     
  Lines       25113    25034      -79     
==========================================
- Hits        23034    23002      -32     
+ Misses       2079     2032      -47     
Impacted Files Coverage Δ
src/include/binder/bound_statement.h 100.00% <ø> (ø)
src/include/binder/bound_statement_visitor.h 50.00% <ø> (+50.00%) ⬆️
src/include/binder/query/bound_regular_query.h 100.00% <ø> (ø)
src/include/binder/query/normalized_single_query.h 100.00% <ø> (ø)
...c/binder/visitor/statement_read_write_analyzer.cpp 100.00% <100.00%> (ø)
...ude/binder/visitor/statement_read_write_analyzer.h 100.00% <100.00%> (ø)
src/main/connection.cpp 93.48% <100.00%> (+0.05%) ⬆️

... and 53 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@andyfengHKU andyfengHKU merged commit 6936d8d into master May 24, 2023
7 checks passed
@andyfengHKU andyfengHKU deleted the statement-ready-only branch May 24, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants