Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add visitor pattern to bound statement #1557

Merged
merged 1 commit into from
May 21, 2023
Merged

Conversation

andyfengHKU
Copy link
Contributor

No description provided.

@andyfengHKU andyfengHKU requested a review from ray6080 May 21, 2023 04:47
@codecov
Copy link

codecov bot commented May 21, 2023

Codecov Report

Patch coverage: 64.33% and project coverage change: -0.17 ⚠️

Comparison is base (cfae96a) 91.87% compared to head (9f6f0e5) 91.71%.

❗ Current head 9f6f0e5 differs from pull request most recent head 80e8fb0. Consider uploading reports for the commit 80e8fb0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1557      +/-   ##
==========================================
- Coverage   91.87%   91.71%   -0.17%     
==========================================
  Files         693      695       +2     
  Lines       24938    24998      +60     
==========================================
+ Hits        22912    22926      +14     
- Misses       2026     2072      +46     
Impacted Files Coverage Δ
src/binder/query/bound_create_clause.cpp 94.44% <ø> (+2.13%) ⬆️
src/binder/query/bound_delete_clause.cpp 100.00% <ø> (+6.66%) ⬆️
src/binder/query/bound_projection_body.cpp 100.00% <ø> (+5.88%) ⬆️
src/binder/query/bound_set_clause.cpp 100.00% <ø> (+11.11%) ⬆️
src/include/binder/bound_statement.h 100.00% <ø> (ø)
src/include/binder/bound_statement_visitor.h 0.00% <0.00%> (ø)
src/include/binder/query/normalized_query_part.h 100.00% <ø> (ø)
src/include/binder/query/normalized_single_query.h 100.00% <ø> (ø)
...e/binder/query/reading_clause/bound_match_clause.h 100.00% <ø> (+4.76%) ⬆️
...binder/query/reading_clause/bound_reading_clause.h 100.00% <ø> (ø)
... and 17 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@andyfengHKU andyfengHKU merged commit deff05a into master May 21, 2023
6 of 7 checks passed
@andyfengHKU andyfengHKU deleted the bound-ast-visitor branch May 21, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants