Push recursive path length into operator #1555
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1555 +/- ##
==========================================
+ Coverage 91.71% 91.90% +0.19%
==========================================
Files 695 693 -2
Lines 24998 24944 -54
==========================================
- Hits 22926 22925 -1
+ Misses 2072 2019 -53
☔ View full report in Codecov by Sentry. |
| offsetVectorPos, common::nodeID_t{path[pathLength - 1], tableID}); | ||
| assert(offsetVectorPos < common::DEFAULT_VECTOR_CAPACITY); | ||
| assert(path[pathLength - 1] == currentDstOffset); | ||
| writeDstNodeOffsetAndLength(dstNodeIDVector, pathLengthVector, offsetVectorPos, tableID); |
There was a problem hiding this comment.
I'm a bit confused about the PR. so it looks like regardless of whether there is or there is not len(p) type expression, you always write path lengths to a value vector. Is that correct?
I was expecting to see a flag that you insert into these operators that will decide whether to write the lengths or not.
There was a problem hiding this comment.
Yes I always write path length to a vector because it's cost is same as writing dst node offsets.
Trying to be smart about writing length is doable but codes becomes a lot complicated after I made the change because we need to switch for track path & length, path & !length, !path & length, !path & !length in multiple places. I decide to go for readability and always write length for now.
Using enum is fine. I've moved from bool to enum.
andyfengHKU
force-pushed
the
recursive-length
branch
from
ac685e4
to
09f0cc7
Compare
No description provided.