Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 1546 #1554

Merged
merged 1 commit into from
May 20, 2023
Merged

Fix issue 1546 #1554

merged 1 commit into from
May 20, 2023

Conversation

andyfengHKU
Copy link
Contributor

This PR fix issue #1546

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (0b3c71e) 91.87% compared to head (1fad22e) 91.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1554      +/-   ##
==========================================
- Coverage   91.87%   91.87%   -0.01%     
==========================================
  Files         693      693              
  Lines       24926    24938      +12     
==========================================
+ Hits        22900    22911      +11     
- Misses       2026     2027       +1     
Impacted Files Coverage Δ
src/include/common/vector/value_vector.h 100.00% <ø> (ø)
src/common/vector/value_vector.cpp 100.00% <100.00%> (ø)
src/function/vector_list_operation.cpp 89.73% <100.00%> (+0.02%) ⬆️
src/include/function/binary_operation_executor.h 69.71% <100.00%> (+0.17%) ⬆️
...lude/function/boolean/boolean_operation_executor.h 75.94% <100.00%> (+0.15%) ⬆️
src/include/function/ternary_operation_executor.h 31.72% <100.00%> (+0.36%) ⬆️
src/include/function/unary_operation_executor.h 72.97% <100.00%> (+0.75%) ⬆️
src/include/storage/storage_structure/column.h 96.36% <100.00%> (+0.13%) ⬆️
...essor/operator/recursive_extend/recursive_join.cpp 84.33% <100.00%> (+0.19%) ⬆️
src/storage/storage_structure/lists/lists.cpp 97.92% <100.00%> (+0.01%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ray6080 ray6080 changed the title fix issue-1546 Fix issue 1546 May 20, 2023
@andyfengHKU andyfengHKU merged commit cfae96a into master May 20, 2023
7 checks passed
@andyfengHKU andyfengHKU deleted the issue-1546 branch May 20, 2023 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants