Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recursive rel logical type #1553

Merged
merged 1 commit into from
May 20, 2023
Merged

Add recursive rel logical type #1553

merged 1 commit into from
May 20, 2023

Conversation

andyfengHKU
Copy link
Contributor

This PR changes the data type of recursive rel from VAR_LIST to RECURSIVE_REL. This is because we are adding functions that work only for RECURSIVE_REL but not for list.

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Patch coverage: 91.66% and project coverage change: +0.01 🎉

Comparison is base (bd235a4) 91.85% compared to head (2341c52) 91.86%.

❗ Current head 2341c52 differs from pull request most recent head 3d680f2. Consider uploading reports for the commit 3d680f2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1553      +/-   ##
==========================================
+ Coverage   91.85%   91.86%   +0.01%     
==========================================
  Files         693      693              
  Lines       24924    24914      -10     
==========================================
- Hits        22893    22888       -5     
+ Misses       2031     2026       -5     
Impacted Files Coverage Δ
...inder/bind_expression/bind_property_expression.cpp 90.24% <ø> (+5.79%) ⬆️
src/common/vector/value_vector.cpp 100.00% <ø> (ø)
src/include/common/types/types.h 100.00% <ø> (ø)
src/include/common/types/value.h 100.00% <ø> (ø)
src/include/common/vector/value_vector.h 100.00% <ø> (ø)
src/common/types/types.cpp 90.90% <50.00%> (+0.57%) ⬆️
src/binder/bind/bind_graph_pattern.cpp 94.32% <100.00%> (-0.48%) ⬇️
src/common/types/value.cpp 92.65% <100.00%> (+0.06%) ⬆️
src/common/vector/auxiliary_buffer.cpp 100.00% <100.00%> (ø)
src/common/vector/value_vector_utils.cpp 100.00% <100.00%> (ø)
... and 2 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

src/common/vector/auxiliary_buffer.cpp Show resolved Hide resolved
src/include/common/types/value.h Show resolved Hide resolved
@andyfengHKU andyfengHKU merged commit 0b3c71e into master May 20, 2023
7 checks passed
@andyfengHKU andyfengHKU deleted the recursive-rel-type branch May 20, 2023 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants