Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undirected query for multi-labelled and unlabelled nodes. #1552

Merged
merged 1 commit into from
May 20, 2023

Conversation

aziz-mu
Copy link
Contributor

@aziz-mu aziz-mu commented May 19, 2023

This commit finishes up implementing undirected query, and includes support for queries in the form:
MATCH (A)-[N]-(B)
MATCH (A|B|C|..)-[N|M|..]-(E|F|G|..)
MATCH ()-[]-()

This pertains to issue #1522

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (4aae989) 91.84% compared to head (00d9ef4) 91.85%.

❗ Current head 00d9ef4 differs from pull request most recent head e215b71. Consider uploading reports for the commit e215b71 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1552   +/-   ##
=======================================
  Coverage   91.84%   91.85%           
=======================================
  Files         693      693           
  Lines       24912    24924   +12     
=======================================
+ Hits        22881    22894   +13     
+ Misses       2031     2030    -1     
Impacted Files Coverage Δ
src/binder/bind/bind_graph_pattern.cpp 94.80% <100.00%> (+0.39%) ⬆️
.../include/parser/query/graph_pattern/node_pattern.h 87.50% <100.00%> (+1.78%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aziz-mu aziz-mu requested a review from andyfengHKU May 19, 2023 14:31
src/include/binder/binder.h Outdated Show resolved Hide resolved
src/include/parser/query/graph_pattern/node_pattern.h Outdated Show resolved Hide resolved
src/binder/bind/bind_graph_pattern.cpp Outdated Show resolved Hide resolved
src/binder/bind/bind_graph_pattern.cpp Outdated Show resolved Hide resolved
src/binder/bind/bind_graph_pattern.cpp Outdated Show resolved Hide resolved
@aziz-mu aziz-mu merged commit bd235a4 into master May 20, 2023
7 checks passed
@aziz-mu aziz-mu deleted the undirected-query branch May 20, 2023 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants