Physical type #1549
Merged
Physical type #1549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1549 +/- ##
========================================
Coverage 91.91% 91.92%
========================================
Files 693 696 +3
Lines 24809 24958 +149
========================================
+ Hits 22804 22942 +138
- Misses 2005 2016 +11
☔ View full report in Codecov by Sentry. |
andyfengHKU
reviewed
May 18, 2023
There was a problem hiding this comment.
I have general questions about when to use physical type and how many getDataTypeSize we should maintain. Let's discuss together @acquamarin @ray6080
ray6080
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Physical datatType VS Logical dataType
Physical Data Types: Represents the actual representations of data in memory or on disk. Two difference logical dataTypes may have the same physical dataType. (E.g. The internal representation of INT32 and DATE is INT32)
Logical Data Types: Represents how the data is perceived and used in queries. Logical data types help determine what operations are valid for a piece of data and how those operations should behave.
2. Todo:
Refactor storage code to use physical dataType instead of logical dataType.